-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lock app orientation to portrait mode on iOS and macOS #1225
base: flutter_app
Are you sure you want to change the base?
fix: lock app orientation to portrait mode on iOS and macOS #1225
Conversation
Reviewer's Guide by SourceryThis pull request locks the app orientation to portrait mode on both iOS and macOS. This was achieved by modifying the Info.plist file for iOS, updating macOS project settings, and adjusting shared schemes. Class diagram for main.dartclassDiagram
class MyApp {
-Key? key
+MyApp(Key? key)
+Widget build(BuildContext context)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samruddhi-Rahegaonkar - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be worth investigating if there's a way to achieve this in the Flutter code itself, rather than modifying platform-specific files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e7775cf
to
63ccea7
Compare
Build StatusBuild successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/13706365344/artifacts/2706119782. Screenshots (Android)
Screenshots (iPhone)
Screenshots (iPad)
|
841eda1
to
11320e8
Compare
<dict> | ||
<key>CADisableMinimumFrameDurationOnPhone</key> | ||
<true/> | ||
<key>CFBundleDevelopmentRegion</key> | ||
<string>$(DEVELOPMENT_LANGUAGE)</string> | ||
<key>CFBundleDisplayName</key> | ||
<string>Badge Magic</string> | ||
<key>CFBundleExecutable</key> | ||
<string>$(EXECUTABLE_NAME)</string> | ||
<key>CFBundleIdentifier</key> | ||
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string> | ||
<key>CFBundleInfoDictionaryVersion</key> | ||
<string>6.0</string> | ||
<key>CFBundleName</key> | ||
<string>badgemagic</string> | ||
<key>CFBundlePackageType</key> | ||
<string>APPL</string> | ||
<key>CFBundleShortVersionString</key> | ||
<string>$(FLUTTER_BUILD_NAME)</string> | ||
<key>CFBundleSignature</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why this was changed?
0a481f0
to
4c91306
Compare
@adityastic Let's rebase this and test :)) |
4c91306
to
2c5ece0
Compare
2c5ece0
to
18d4b70
Compare
@adityastic There we go ! |
Awesome! Great job! |
Fixes
-This PR fixes issue #1190 by locking the app's orientation to portrait mode on both iOS and macOS platforms.
Changes
Screenshots / Recordings
Checklist:
constants.dart
without hard coding any value.Fixes #1190.
Summary by Sourcery
Bug Fixes: