Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): replace headlessui Switch with radix-ui #3774

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

erka
Copy link
Contributor

@erka erka commented Dec 31, 2024

related #3759

@erka erka requested a review from a team as a code owner December 31, 2024 13:03
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (7c2520e) to head (700ac0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3774   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files         171      171           
  Lines       17391    17391           
=======================================
  Hits        11277    11277           
  Misses       5418     5418           
  Partials      696      696           
Flag Coverage Δ
unittests 64.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ty!

@erka erka merged commit 1c01075 into main Jan 1, 2025
39 checks passed
@erka erka deleted the rd/ui-radix-switch branch January 1, 2025 09:13
markphelps added a commit that referenced this pull request Jan 1, 2025
…lipt-io/flipt into devin/1733937099-flag-metadata

* 'devin/1733937099-flag-metadata' of https://github.com/flipt-io/flipt:
  refactor(ui): replace headlessui Switch with radix-ui (#3774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants