Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): support Victoria Metrics with Prometheus storage #3663

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

erka
Copy link
Contributor

@erka erka commented Nov 28, 2024

This pull request includes several changes to the internal/server/analytics/prometheus package to improve the handling of data from Prometheus and Victoria Metrics, as well as to enhance testing capabilities.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.34%. Comparing base (256d122) to head (692c07b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3663      +/-   ##
==========================================
+ Coverage   64.28%   64.34%   +0.05%     
==========================================
  Files         170      170              
  Lines       17025    17031       +6     
==========================================
+ Hits        10945    10958      +13     
+ Misses       5398     5392       -6     
+ Partials      682      681       -1     
Flag Coverage Δ
unittests 64.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the rd/analytics-prometheus branch from 4e95462 to 692c07b Compare November 29, 2024 09:55
@erka erka marked this pull request as ready for review November 29, 2024 10:09
@erka erka requested a review from a team as a code owner November 29, 2024 10:09
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@erka erka merged commit 70295f8 into main Nov 29, 2024
39 checks passed
@erka erka deleted the rd/analytics-prometheus branch November 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants