Fixed crash in QMetaObject creation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #56 by ensuring parameters pointers doesn't get invalidated by reallocations. The idea is to just create before hand the parameters sequences and only later reference the elements in the signal and slots structs. This makes the code safe since the sequences are immutable (and so cannot be reallocated)
filcuc
force-pushed
the
slot_creation_crash
branch
from
9a3a8c4 to
e9e0923
Compare
arnetheduck
pushed a commit
to arnetheduck/nimqml-miqt-poc
that referenced
this pull request
Feb 11, 2025
feat: add support for float64 as QMetatype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6 by ensuring parameters pointers doesn't get invalidated by reallocations. The idea is to just create before hand the parameters sequences and only later reference the elements in the signal and slots structs. This makes the code safe since the sequences are immutable (and so cannot be reallocated)