Refactor code to use penalty_factor method and update documentation
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etagwerker
requested review from
mateusdeap and
KostiantynPopovych
and removed request for
a team
etagwerker
added a commit
that referenced
this pull request
Nov 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 25 25
Lines 463 465 +2
=======================================
+ Hits 455 457 +2
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also, update documentation for the `skunk_score` method. Also, stop using byebug and start using Ruby's debugger. Update CHANGELOG.md to document #102
etagwerker
force-pushed
the
fixes/documentation-and-refactors-code
branch
from
d3952f9 to
f9e9f15
Compare
etagwerker
requested review from
JuanVqz
and removed request for
mateusdeap and
KostiantynPopovych
|
approved, good refactor, I'm happy to see you added the debug gem, it's a lovely gem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issue, make sure you include Closes #XXXX in your comment.
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description:
Hi there,
This PR fixes #101.
Also, it updates documentation for the
skunk_scoremethod and changes a development dependency to stop using byebug and start using Ruby's debugger.If changes to the behavior are made, clearly describe what changes.
I will abide by the code of conduct.