Replace std::iostream use with stdio in FastPFor lib #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation would fail if STATS is enabled in util.h
pps83
changed the title
pps83
force-pushed
the
master-msvc-fixes
branch
from
68a5bfa to
56c8bec
Compare
+ remove unused printme
+ change ASSERT macro to take message as an std::string
Even basic use of iostream pulls in dependencies that are almost as big in code size as the rest of the FastPFor library itself. Consider the following simple example that pulls in all codecs from codecfactory compiled with static runtime with VS2022:
```
#include "codecfactory.h"
int main()
{
for (auto codec : FastPForLib::CODECFactory().allSchemes())
{
size_t z;
codec->encodeArray((uint32_t*)0, 0, 0, z);
codec->decodeArray(0, 0, (uint32_t*)0, z);
}
}
```
When using std::iostream resulting binary is 834KB. When using stdio resulting binary is 571KB.
pps83
force-pushed
the
master-msvc-fixes
branch
from
56c8bec to
71b0425
Compare
|
Looks fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing std:: when STATS enabledis a simple fix.Replace std::iostream use with stdio in FastPFor lib- is a good change imo, but it may have issues.All uses of std::cout/cerr were replaced with printf, and even if the changes didn't introduce errors (please double check), there might be issues with printf modifiers with old compilers. For example,
%zuis available starting from VS2013. In any case, that's a 10-year old version of VS