Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ReactPerf doesn’t free memory in DEV when not profiling #6750

Closed
gaearon opened this issue May 11, 2016 · 0 comments · Fixed by #6753
Closed

New ReactPerf doesn’t free memory in DEV when not profiling #6750

gaearon opened this issue May 11, 2016 · 0 comments · Fixed by #6753
Assignees
@gaearon
Labels
Type: Regression
Milestone
15.2.0

Comments

@gaearon
Copy link
Collaborator

gaearon commented May 11, 2016

We purge it here but this code doesn’t run because of the early exit.

Need to fix this and add a test case to make sure we don’t regress on it.
@gaearon gaearon self-assigned this May 11, 2016
@gaearon gaearon added this to the 15.1.0 milestone May 11, 2016
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
9b7a301 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
3d48fea 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
6ea78a6 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
@gaearon gaearon mentioned this issue May 12, 2016
Merged
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
d912a94 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
427cb39 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
gaearon added a commit that referenced this issue May 12, 2016
@gaearon
Fix a memory leak in ReactComponentTreeDevtool
3779a5d 
`ReactDebugTool` used to only call `purgeUnmountedComponents()` while profiling, so information about unmounted instances kept accumulating when not profiling.

Additionally, unmounting in React Native and rendering to string did not correctly clean up the devtool.

Finally, the tests tested the wrong behavior and relied on explicit `purgeUnmountedComponent()` calls.

To fix this, we:

* Test specifically that unmounting is enough to clean up the tree devtool.
* Add missing `onBeginFlush` and `onEndFlush` calls to server and native rendering so `ReactDebugTool` knows when to copy the tree.

Fixes #6750
@zpao zpao modified the milestones: 15.1.0, 15.y.0 May 20, 2016
@zpao zpao modified the milestones: 15.y.0, 15-next Jun 1, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaearon gaearon

Labels
Type: Regression
Projects
None yet
Milestone
15.2.0
Development

Successfully merging a pull request may close this issue.

Fix a memory leak in ReactComponentTreeDevtool facebook/react
2 participants
@zpao @gaearon