Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inverted pv meter power sign (#643) #649

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

rivengh
Copy link
Contributor

@rivengh rivengh commented Feb 6, 2021

PV meter power generation shall be considered as a positive value instead of negative value, to align with user expectation and common inverter API values

@andig
Copy link
Member

andig commented Feb 6, 2021

Das nutzt so nix. Assets.go muss auch gebaut werden und die Nomenklatur gehört endlich in die README. Aber guter Versuche, danke 👍🏻

@rivengh
Copy link
Contributor Author

rivengh commented Feb 6, 2021

Das nutzt so nix. Assets.go muss auch gebaut werden

War ja auch erstmal nur als kleiner Anfang gedacht ;-)
Assets.go habe ich noch gebaut.

und die Nomenklatur gehört endlich in die README.

Ja, auf jeden Fall 👍🏻

@andig andig merged commit b5dfb4f into evcc-io:master Feb 7, 2021
@rivengh rivengh deleted the invert-pv-meter-power-sign branch February 7, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants