Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDM: add tempsource top/bottom (BC) #19249

Merged
merged 2 commits into from
Feb 28, 2025
Merged

IDM: add tempsource top/bottom (BC) #19249

merged 2 commits into from
Feb 28, 2025

Conversation

mathiasmora
Copy link
Contributor

Warmwatersensor Down (Register 1012) added in choice for tempsource

Warmwatersensor Down added in choice for tempsource
@mathiasmora mathiasmora mentioned this pull request Feb 27, 2025
@andig andig added the heating Heating label Feb 28, 2025
@andig
Copy link
Member

andig commented Feb 28, 2025

Der müsste dann „lower“ statt „down“ heissen?

@mathiasmora
Copy link
Contributor Author

Oder vermutlich wäre bottom sogar noch besser. Das eine ist der Sensor unten bzw. am Boden vom Wärmespeicher und der andere oben.

@andig
Copy link
Member

andig commented Feb 28, 2025

Sehr gut. Dann mach noch top und wir nehmen das als breaking change.

Renaming warmwater top/bottom
@mathiasmora mathiasmora changed the title IDM: Add Tempsensor warmwater_down IDM: Add choice tempsource warmwater top/bottom Feb 28, 2025
@andig andig changed the title IDM: Add choice tempsource warmwater top/bottom IDM: add tempsource top/bottom (BC) Feb 28, 2025
@andig andig merged commit ba5e6a0 into evcc-io:master Feb 28, 2025
@mathiasmora mathiasmora deleted the patch-2 branch February 28, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
heating Heating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants