Tibber Pulse: fix duplicate subscriptions

[GrimmiMeloni]

According to graphql-client maintainers, resubscribing after client disconnect has become counterproductive after the recent changes.
Removing the re-subscribe should fix the duplicate subscriptions observed here.

@andig I used go get github.com/hasura/go-graphql-client@5970b87 to update the client. Looking at the change set, I see there's now two entries for graphql in go.sum. Is this OK/correct, or should the previous entry be removed? If the latter, any reason why go get did not do so on its own?

Nevermind, broke porcelain - fixed it.

[andig]

Another great PR, thank you! Wondering: do we even need the ticker now? Is there anything stopping the client from running?

[GrimmiMeloni]

Another great PR, thank you! Wondering: do we even need the ticker now?

Yes. To my understanding we will otherwise see 429s again, regression of #18635

Is there anything stopping the client from running?

Yes, to my understanding, the part of the client lib that ends SubscriptionClient.Run() when failing the subscribe message is still in. So the client (i.e. .Run()) will still stop/exit when Tibber has its hiccup where it incorrectly claims the subscription is invalid.

[GrimmiMeloni]

Bonus question: Shall we inline Tibber.ensureSubscribed() again? We are back to only needing this during the first initialization.

[andig]

Yes pls plus get rid of the membrr vars. Simpler to revert that commit?

[andig]

Top, vielen Dank!