Add Toyota #18716
Merged
Add Toyota #18716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From here it should be easily possible to also retrieve the climate state.
Great Review! 👍 |
andig
reviewed
Feb 14, 2025
Need to do another round, sorry :/ |
andig
reviewed
Feb 14, 2025
…pe/accept headers
thomasbecker
force-pushed
the
feat/toyota
branch
from
ef78443 to
0a2bdb9
Compare
andig
reviewed
Feb 14, 2025
As many as necessary. Am new to go so happy about every feedback to learn. 👍 |
|
The point here is to avoid the ducktyping. If you need more than the interface, either expand that or simply use the actual type (...which still fulfills the interface!). |
Yep, much cleaner that way. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Toyota to the vehicle list. Retrieving SOC works fine for my bZ4X.
Should be easy enough from here to also read the climate state, etc.
