-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiat: support start/stop charge on TWC3 #18028
Conversation
…ram to enable charge control
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
…id errors ad per @andig comments
I think description needs a comment that this can be used with TWC3 and that it will then overwrite schedules. |
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
@andig not creating the controller if pin is empty will create nil pointer exception as TWC3 implementation is trying to call it. goroutine 129 [running]: Please advise what would be the best solution for this. IMHO returning ErrMissingCredentials is explicit enough. Just testing this situation as confirming the missing credentials exception is thrown and handled nicely by evcc (and displayed to the end user in the UI): [lp-1 ] DEBUG 2025/01/05 14:35:44 pv charge current: 0A = 3.3A + -3.75A (2589W @ 3p) |
…s configured. Instead in this case, throw ErrMissingCredentials which is nicely handled by EVCC.
Tbo, I'm still not convinced that this should get merged. The setup will only work if 16A current is available and/or produce highly unexpected and undocumented results. |
Co-authored-by: andig <[email protected]>
As per EVCC stats, I’ve reached 59.7% of solar charge on my 500e mostly due to this. |
Ah, that helps. Lets go... |
As we are still waiting for OCCP support for TWC3 with no idea when (and if) it may come, I propose to add support for starting & stopping in the fiat implementation based on charge schedule when used with a TWC3 charger (or other charger relying on vehicle controller to start/stop charge).
This implementation will take control of the first schedule available from the FIAT app and use it to ask the vehicle to start or stop the charge based on the time. If evcc decides to start the charge, then all other charge schedule will be disabled to avoid conflict (no climate schedule will be changed).
I’ve been using this implementation since July in a custom build without any issues.