Updated PUN tariff to use the new GME website #17900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the download process to use the new GME site. Added some comments and logging.
Added code to manage next day not yet available
removed commented code
|
Bitte formatieren und Linter fixen- vielen Dank! |
andig
reviewed
Dec 27, 2024
Co-authored-by: andig <[email protected]>
removed log code
removed additiona log code
Removed unnecessary spaces and reverted to original log code
Uses new GME site. Removed unnecessary log code
|
Should comply with the changes requested. |
andig
requested changes
Dec 29, 2024
applied suggestions Co-authored-by: andig <[email protected]>
jonilala796
pushed a commit
to jonilala796/evcc
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I managed to fix the PUN tariff retrieval using the new GME site thanks to the great work of @virtualdj with https://github.com/virtualdj/pun_sensor
This should (I hope) definitely close #17174
Added code to better log the various steps needed to retrieve data.