-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for megawatt #15818
Add support for megawatt #15818
Conversation
👍 Looks really good. You've picked a first issue that touches a lot of different parts of the UI :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can merge once the last comments are done (and the tests are green).
use `kw`-unit for 0 watt if `format` is specified as `AUTO` use 1 digit for 0 watt if `digits` is specified as `undefined`
Thanks! 🙌 |
Hi,
this PR adds support for the unit
megawatt
and its display on the screen.If support for
gigawatt
is wanted I can add this, too.I also changed the tests to work with the new enum.
I was unsure how I should export the enum.
If the current solution is not correct, please let me know so that I can learn from it and improve it.
Also, I was unsure if I should rename this function:
Fixes #15290
Thank you very much for this great project!
~ Maschga