Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make decorate dependency-aware #15434

Merged
merged 12 commits into from
Aug 18, 2024
Merged

Conversation

andig
Copy link
Member

@andig andig commented Aug 16, 2024

Reduce combinatorial complexity by eliminating invalid combinations: https://github.com/evcc-io/evcc/pull/15434/files#diff-e149a97460e875de78b30ce55504f72e6e43b60ec9beac533c8b9cfef00cf828R32-R36.

On Mac Arm64, recreating assets reduces binary size from 95MB to 90MB. Binary size reduction is offset by adding optional values to charger.

Refs and improves #14546: custom chargers can now directly implement phase voltages and currents.

Refs https://stackoverflow.com/questions/78881749/how-to-get-the-static-reflect-type-of-an-interface.

@andig andig added the infrastructure Basic functionality label Aug 16, 2024
@andig andig requested a review from GrimmiMeloni August 16, 2024 15:44
@GrimmiMeloni
Copy link
Collaborator

@andig i am currently travelling. happy to help with this next week.

@naltatis
Copy link
Member

@andig Die Tests schlagen fehl, weil der Heating-Use-Case damit nicht mehr korrekt funktioniert. Es wird % anstatt Celsius in der UI angezeigt.

Test: https://github.com/evcc-io/evcc/blob/master/tests/heating.spec.js
Config: https://github.com/evcc-io/evcc/blob/master/tests/heating.evcc.yaml

@andig andig marked this pull request as draft August 17, 2024 21:27
@andig
Copy link
Member Author

andig commented Aug 17, 2024

Ohja, böser Fehler und super schwer zu finden. Danke!

@andig andig marked this pull request as ready for review August 18, 2024 09:02
@andig andig requested a review from premultiply August 18, 2024 10:10
@premultiply
Copy link
Member

premultiply commented Aug 18, 2024

Sehr schön, aber brauchen wir bei den Chargern überhaupt die powers?

@andig
Copy link
Member Author

andig commented Aug 18, 2024

Good point. Raus damit und dann rein damit :)

@andig andig merged commit 15a3dee into master Aug 18, 2024
6 checks passed
@andig andig deleted the chore/decorate-with-dependencies branch August 18, 2024 10:26
andig added a commit that referenced this pull request Aug 20, 2024
@andig andig mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Basic functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants