Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost limit: show negative price options, add 0.5ct steps #14021

Merged
merged 3 commits into from
May 24, 2024
Merged

Cost limit: show negative price options, add 0.5ct steps #14021

merged 3 commits into from
May 24, 2024

Conversation

naltatis
Copy link
Member

fixes #14020

  • 🪲 use floor (instead of ceil) to determin the lowes limit option based on current tariffs (see here)
  • 0️⃣ fix issue where both none and <= 0 options appeared (type mismatch)
  • 📉 always show at least 10 negative limit options (only for price, not for co2)
  • 🤏 add finer steps (e.g. 0.05ct) when they make sense

Bildschirmfoto 2024-05-22 um 11 56 42

@naltatis naltatis added bug Something isn't working enhancement New feature or request ux User experience/ interface labels May 22, 2024
@naltatis naltatis merged commit ae6cfbe into master May 24, 2024
6 checks passed
@naltatis naltatis deleted the feature/limit_selection branch May 24, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request ux User experience/ interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow negative price limit selection
1 participant
@naltatis