-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EdgeTech Smart EVSE #13946
Add EdgeTech Smart EVSE #13946
Conversation
@premultiply was fehlt noch? |
@swallage ok? |
All check passed, great! Should I check out the unstable branch to verify? |
@swallage please check out this PR for testing! If not possible we could merge as-is and you can test in nightly. |
I just started to test it. It seems however that the features |
@andig : at the moment the board only supports a hardware lock (that locks the plug) or a CP-disconnects requires additional hardware. So when the features cphwonlock and cpwakeauto are not available that is fine. The line 243-246 is a different issue. Let me check |
Your suggestion seems better as it avoids specifying the value at different places. As I am not a Go-expert, this double check: |
This comment was marked as outdated.
This comment was marked as outdated.
Yes, it is the same. |
If the hardware supports wake-up it always should handle it by itself. So there is no need to do any special handling by evcc or special config vars to be set by the user. Hint: Maybe you can alter the firmware to skip the crude and not recommended relais solution on CP line at all and provide just the -12V on CP by EVSE for wake-up assist function as defined by EV40. “E.V. READY” CERTIFICATION TECHNICAL REFERENCE DOCUMENT EV40: |
Cool @premultiply , thanks a lot. We were not that happy with the CP-disconnect using a relay. |
@premultiply : see the issue #13946 (comment) above. Not sure what happened with the cphwonlock feature (requires additional hardware, but feature was in original PR). |
Perhaps @andig removed the HW-lock feature. For me that is fine for now. We have to look at CP disconnect again after the suggestion of @premultiply . Is the PR good enough to merge into the main tree? |
I removed it as if it exists it should be handled by EVSE itself without any configuration needs on evcc side. |
So cool, does that mean the charger will be merged? |
😃 |
Replaces #13852