Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config UI: General layout #13166

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Config UI: General layout #13166

merged 1 commit into from
Mar 28, 2024

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Mar 27, 2024

extracted part from #12958
prerequisite for "password change" #11732 and other non-device configurations

  • ↔ use full layout width on larger screens
  • 🍱 compact view of all non-device setting state
    • moved update/edit logic to separate screens/modals
    • cleaner ui. these settings will not be updated frequently
    • purpose of each setting or setting-group (e.g. port+host+protocol=network) can be explained on the separate screen
  • πŸ’¬ refactored modal handling (introduced generic component)

⚠️ Only "title" and "telemetry" are editable right now. Other settings are present (and disabled) to get a feeling for future layout requirements. Unimplemented entries will be hidden once Config UI available in a first non-experimental state.

πŸ—’οΈ Some texts are not translated yet, because this area is still subject to change, and we don't want to trigger unnecessary translation cycles. We'll translate them once we move out of experimental.

large screen: after

lg after

large screen: before

lg before

medium screen: after

md after

medium screen: before

md before

@naltatis naltatis added the ux User experience/ interface label Mar 27, 2024
@naltatis naltatis requested a review from andig March 27, 2024 10:00
@naltatis naltatis assigned naltatis and unassigned andig Mar 27, 2024
@RTTTC
Copy link
Contributor

RTTTC commented Mar 27, 2024

Wow, next release will have many nice improvements! Nice work! 😎

@naltatis naltatis merged commit 198e94e into master Mar 28, 2024
6 checks passed
@naltatis naltatis deleted the feature/config-general-layout branch March 28, 2024 09:27
naltatis added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants