Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters from "nworkers" to "num-threads" #1270

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

albestro
Copy link
Collaborator

As per discussion in the last meeting, we are doing this breaking change on parameter names:

  • dlaf:red2band-panel-nworkers becomes dlaf:red2band-panel-num-threads
  • dlaf:tridiag-rank1-nworkers becomes dlaf:tridiag-rank1-num-threads

This change applies also to related environment variables names.

@albestro albestro added this to the v0.8.0 milestone Feb 11, 2025
@albestro albestro self-assigned this Feb 11, 2025
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better if the get_* functions are called in the same way as the parameter (e.g. get_red2band_panel_num_threads instead of get_red2band_panel_num_workers)?

@albestro
Copy link
Collaborator Author

albestro commented Feb 12, 2025

Wouldn't be better if the get_* functions are called in the same way as the parameter (e.g. get_red2band_panel_num_threads instead of get_red2band_panel_num_workers)?

I thought about that (and with that also the variables): my opinion is that algorithmically makes sense (to me) that I consider them "workers" independently from the backend, i.e. being them threads or streams.

@albestro albestro force-pushed the alby/fix-param-names branch from 239ba13 to aff73e3 Compare February 13, 2025 11:01
@rasolca
Copy link
Collaborator

rasolca commented Feb 18, 2025

cscs-ci run

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.07%. Comparing base (47a58ea) to head (1fb2cd3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/tune.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         141      141           
  Lines        8655     8655           
  Branches     1110     1110           
=======================================
  Hits         8229     8229           
  Misses        239      239           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rasolca rasolca merged commit a9abb81 into master Feb 18, 2025
5 checks passed
@rasolca rasolca deleted the alby/fix-param-names branch February 18, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants