-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename parameters from "nworkers" to "num-threads" #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be better if the get_*
functions are called in the same way as the parameter (e.g. get_red2band_panel_num_threads
instead of get_red2band_panel_num_workers
)?
I thought about that (and with that also the variables): my opinion is that algorithmically makes sense (to me) that I consider them "workers" independently from the backend, i.e. being them threads or streams. |
239ba13
to
aff73e3
Compare
cscs-ci run |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 141 141
Lines 8655 8655
Branches 1110 1110
=======================================
Hits 8229 8229
Misses 239 239
Partials 187 187 ☔ View full report in Codecov by Sentry. |
As per discussion in the last meeting, we are doing this breaking change on parameter names:
dlaf:red2band-panel-nworkers
becomesdlaf:red2band-panel-num-threads
dlaf:tridiag-rank1-nworkers
becomesdlaf:tridiag-rank1-num-threads
This change applies also to related environment variables names.