TFactor: use optimised kernel #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albestro
force-pushed
the
alby/tfactor-optim/bulk
branch
from
152f8e7 to
0d2bd4f
Compare
rasolca
previously requested changes
Jan 27, 2025
msimberg
approved these changes
Jan 28, 2025
albestro
force-pushed
the
alby/tfactor-optim/bulk
branch
5 times, most recently
from
175fc6d to
aaba87f
Compare
albestro
force-pushed
the
alby/tfactor-optim/bulk
branch
2 times, most recently
from
0d2def8 to
c306078
Compare
albestro
force-pushed
the
alby/tfactor-optim/kernel
branch
from
efed0f0 to
8b66843
Compare
most trivial solution, at least as a starting point
albestro
force-pushed
the
alby/tfactor-optim/kernel
branch
from
8b66843 to
1017eab
Compare
msimberg
approved these changes
Feb 13, 2025
|
cscs-ci run |
|
For what concerns the |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 141 141
Lines 8655 8655
Branches 1110 1110
=======================================
Hits 8229 8229
Misses 239 239
Partials 187 187 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a joint effort to optimise TFactor, with #1219 a faster kernel for LARFT has been introduced, and here it is applied on top of #1214 which parallelises it.
TODO:
think about best solution about how to either copy taus or provide them toEDIT: tracked by TFactor: Store taus on GPU for reduction to band and its back transformation #1282_fixtau