Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gainmap metadata #255

Merged
merged 9 commits into from
Mar 2, 2025
Merged

Gainmap metadata #255

merged 9 commits into from
Mar 2, 2025

Conversation

awxkee
Copy link
Contributor

@awxkee awxkee commented Mar 1, 2025

You better check this with care, I'm not the very best in JPEGs parsing

@awxkee
Copy link
Contributor Author

awxkee commented Mar 1, 2025

Perhaps we could change pub gain_map_info: Vec<GainMapInfo>, to pub gain_map_info: Option<GainMapInfo>, if there is no plans to parse the whole image at one time ?
It doesn't look like is expected on libultrahdr to have multiple gain map metadata stored in the one image.

@awxkee
Copy link
Contributor Author

awxkee commented Mar 1, 2025

Here is MPF parser, looks like everything works.

Except that secondary image offset point before the first image ends, however images sizes is correct, so probably offset computed from somewhere not at start from the file.
Screenshot 2025-03-01 at 22 07 01

@etemesi254 etemesi254 merged commit bc91891 into etemesi254:dev Mar 2, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants