-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract rangeEvents function #18981
Extract rangeEvents function #18981
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b52ee3b
to
ae2d87b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18981 +/- ##
==========================================
- Coverage 68.80% 68.76% -0.04%
==========================================
Files 420 420
Lines 35599 35602 +3
==========================================
- Hits 24494 24483 -11
- Misses 9675 9688 +13
- Partials 1430 1431 +1 Continue to review full report in Codecov by Sentry.
|
ae2d87b
to
af92e6f
Compare
pull-etcd-verify failed with.
This is useless information. Can't reproduce locally, |
/retest |
af92e6f
to
948b445
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
948b445
to
1f4439c
Compare
type contains interface { | ||
contains(string) bool | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make much sense to add an interface here. I didn't raise this comment in #17563 is because you removed it in your second commit.
@serathius: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What do you mean ? Did |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.