Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rangeEvents function #18981

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

serathius
Copy link
Member

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (78885f6) to head (1f4439c).
Report is 5 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/watchable_store.go 93.55% <100.00%> (+0.06%) ⬆️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18981      +/-   ##
==========================================
- Coverage   68.80%   68.76%   -0.04%     
==========================================
  Files         420      420              
  Lines       35599    35602       +3     
==========================================
- Hits        24494    24483      -11     
- Misses       9675     9688      +13     
- Partials     1430     1431       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78885f6...1f4439c. Read the comment docs.

@serathius
Copy link
Member Author

pull-etcd-verify failed with.

  % (cd server && 'golangci-lint' 'run' '--config' '/home/prow/go/src/github.com/etcd-io/etcd/tools/.golangci.yaml' './...')
storage/mvcc/watchable_store_test.go:236: File is not `gofumpt`-ed (gofumpt)

This is useless information. Can't reproduce locally,

@serathius
Copy link
Member Author

/retest

@serathius
Copy link
Member Author

cc @mmorel-35 @jmhbnz

Signed-off-by: Marek Siarkowicz <[email protected]>
Comment on lines +431 to +433
type contains interface {
contains(string) bool
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make much sense to add an interface here. I didn't raise this comment in #17563 is because you removed it in your second commit.

@k8s-ci-robot
Copy link

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-386 1f4439c link true /test pull-etcd-e2e-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius merged commit 1f4439c into etcd-io:main Dec 2, 2024
31 of 34 checks passed
@mmorel-35
Copy link
Contributor

Can't reproduce locally,

What do you mean ? Did make fix-lint not fixed the issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants