esp-hal: add doctest showing how to use Jiff #3232
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to add a doctest showing how to plug a micro-second Unix timestamp into Jiff, and then get, e.g., the weekday in a particular locale. The example also makes use of Jiff's new `tz::get!` proc-macro for embedding time zones into the binary for use in core-only environments. Ref esp-rs#3185, Ref esp-rs#3200
|
I couldn't figure out how to make the test actually runnable, so it's tagged with |
Dominaezzz
approved these changes
Mar 6, 2025
bjoernQ
approved these changes
Mar 7, 2025
bugadani
reviewed
Mar 7, 2025
| /// let rtc = Rtc::new(peripherals.LPWR); | ||
| /// let now = Timestamp::from_microsecond( | ||
| /// rtc.current_time_us() as i64, | ||
| /// ).unwrap(); |
There was a problem hiding this comment.
I thought we don't want unwraps in doctests anymore
There was a problem hiding this comment.
I will have a look after it's merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to add a doctest showing how to plug a micro-second Unix
timestamp into Jiff, and then get, e.g., the weekday in a particular
locale. The example also makes use of Jiff's new
tz::get!proc-macrofor embedding time zones into the binary for use in core-only
environments.
Ref #3185, Ref #3200