Add degrade fns, move AnyI2s and AnyI2c #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominaezzz
approved these changes
Mar 6, 2025
Co-authored-by: Dominic Fischer <[email protected]>
JurajSadel
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3205
I'm also moving the AnyI2c and AnyI2s types, but really only because of the macro change. We now generate
degradefor singletons automatically, and if we were to introduce a separate AnyI2c for slave mode for example, we would have multiple implementations of the same function. I also don't think the peripheral instances themselves will be different, the drivers may decorate them with marker/instance traits as needed.