Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of dead I2C code #3224

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Remove a bunch of dead I2C code #3224

merged 1 commit into from
Mar 6, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Mar 6, 2025

No description provided.

@bugadani bugadani added the skip-changelog No changelog modification needed label Mar 6, 2025
@bugadani bugadani marked this pull request as ready for review March 6, 2025 10:55
bjoernQ
bjoernQ approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and my VL53L5 still works on ESP32

@jessebraham jessebraham added this pull request to the merge queue Mar 6, 2025
Merged via the queue into esp-rs:main with commit d27488e Mar 6, 2025
28 checks passed
@bugadani bugadani deleted the i2c-timeout branch March 6, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @jessebraham @bjoernQ