Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spi: docs improvement, re-shuffle and merge impl blocks #3223

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

JurajSadel
Copy link
Contributor

Second driver of #3180. This doesn't change logic of the driver just reshuffle some functions.

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Mar 6, 2025
@bugadani
Copy link
Contributor

bugadani commented Mar 6, 2025

If you're already touching this file, could you please fix the formatting of the doc example?

image

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 6, 2025

I wonder why unstable functions render differently

image

vs

image

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 6, 2025

And - while it was like that before probably - why we have interrupts/listen/unlisten/clear_interrupts only on SpiDma

@bugadani
Copy link
Contributor

bugadani commented Mar 6, 2025

why we have interrupts/listen/unlisten/clear_interrupts only on SpiDma

This is one of the reasons why interrupts are unstable at this point :)

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 7, 2025

I wonder why unstable functions render differently

Seems the macro generates the same code. Apparently, in the rustdoc JSON output it's not the same but we probably can't do anything about it

@bugadani bugadani added this pull request to the merge queue Mar 7, 2025
Merged via the queue into esp-rs:main with commit cdcd3be Mar 7, 2025
27 checks passed
@JurajSadel JurajSadel deleted the spi branch March 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants