-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uart: minor docs improvements #3216
Conversation
We should maybe also merge the separate Blocking and Async blocks, we don't need multiple of them. |
I could have been a bit more clear in the original issue, sorry about that!
Re grouping inside the blocks, I think I agree with @bugadani's point (#3216 (comment)). This is more inline with how upstream Rust does it, for example: https://doc.rust-lang.org/core/primitive.i32.html#method.strict_add is placed next to the other add functions. Let's just try and organize it so that at the very least the first few items we see for a driver are stable, if possible please :D.
Good idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for updating the guidelines too!
First driver of #3180. This doesn't change logic of the driver just reshuffle some functions.
I think I will work on one driver at a time to avoid ugly rebasing of multiple files.