Fix nightly CI errors

.github/workflows/ci_nightly.yml

@@ -12,7 +12,6 @@ env:
   DEFMT_LOG: trace
 
 jobs:
-
   esp-hal-nightly:
     name: esp-hal | nightly (${{ matrix.device.soc }})
     runs-on: ubuntu-latest
@@ -52,20 +51,18 @@ jobs:
           target: ${{ matrix.device.target }}
           toolchain: nightly
 
-      - name: Create or Update GitHub Issue
-        if: failure()
+      - if: failure()
+        name: Create or Update GitHub Issue
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           sudo apt-get install gh -y
           ISSUE_NAME=$(gh issue list --state open --search "Nightly CI Failure in:title" --json number --jq '.[0].number')
 
-          if [[ -n "$ISSUE_NAME" ]]; then
-            gh issue comment "$ISSUE_NAME" \
-              --body "Another CI failure detected! [View the failed job](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})."
-          else
+          if [[ -n "$ISSUE_NAME" ]];
+          then
             gh issue create \
               --title "Nightly CI Failure" \
               --body "Nightly CI Workflow Failed! [View the failed job](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})." \
               --label "ci-nightly"
           fi
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

esp-hal/src/soc/efuse_field.rs

@@ -71,7 +71,7 @@ impl Efuse {
             }
 
             // get data length in bytes (ceil)
-            let byte_len = (word_bit_len + 7) / 8;
+            let byte_len = word_bit_len.div_ceil(8);
             // represent word as a byte slice
             let word_bytes =
                 unsafe { core::slice::from_raw_parts(&word as *const u32 as *const u8, byte_len) };

esp-ieee802154/src/hal.rs

@@ -271,7 +271,7 @@ pub(crate) fn set_multipan_enable_mask(mask: u8) {
     // apparently the REGS are garbage and the struct is right?
     IEEE802154::regs()
         .ctrl_cfg()
-        .modify(|r, w| unsafe { w.bits(r.bits() & !(0b1111 << 29) | (mask as u32) << 29) });
+        .modify(|r, w| unsafe { w.bits(r.bits() & !(0b1111 << 29) | ((mask as u32) << 29)) });
 }
 
 #[inline(always)]

esp-lp-hal/src/gpio.rs

@@ -39,7 +39,7 @@ pub struct Input<const PIN: u8>;
 impl<const PIN: u8> Input<PIN> {
     /// Read the input state/level of the pin.
     pub fn input_state(&self) -> bool {
-        unsafe { &*LpIo::PTR }.in_().read().bits() >> PIN & 0x1 != 0
+        (unsafe { &*LpIo::PTR }.in_().read().bits() >> PIN) & 0x1 != 0
     }
 }
 
@@ -49,7 +49,7 @@ pub struct Output<const PIN: u8>;
 impl<const PIN: u8> Output<PIN> {
     /// Read the output state/level of the pin.
     pub fn output_state(&self) -> bool {
-        unsafe { &*LpIo::PTR }.out().read().bits() >> PIN & 0x1 != 0
+        (unsafe { &*LpIo::PTR }.out().read().bits() >> PIN) & 0x1 != 0
     }
 
     /// Set the output state/level of the pin.

esp-lp-hal/src/i2c.rs

@@ -206,7 +206,7 @@ impl LpI2c {
         self.add_cmd_lp(&mut cmd_iterator, Command::Start)?;
 
         // Load device address and R/W bit into FIFO
-        self.write_fifo(addr << 1 | OperationType::Write as u8);
+        self.write_fifo((addr << 1) | OperationType::Write as u8);
 
         self.add_cmd_lp(
             &mut cmd_iterator,
@@ -285,7 +285,7 @@ impl LpI2c {
         self.add_cmd_lp(&mut cmd_iterator, Command::Start)?;
 
         // Load device address
-        self.write_fifo(addr << 1 | OperationType::Read as u8);
+        self.write_fifo((addr << 1) | OperationType::Read as u8);
 
         self.add_cmd_lp(
             &mut cmd_iterator,
@@ -297,7 +297,7 @@ impl LpI2c {
         )?;
 
         self.enable_interrupts(
-            1 << LP_I2C_TRANS_COMPLETE_INT_ST_S | 1 << LP_I2C_END_DETECT_INT_ST_S,
+            (1 << LP_I2C_TRANS_COMPLETE_INT_ST_S) | (1 << LP_I2C_END_DETECT_INT_ST_S),
         );
 
         let mut remaining_bytes = buffer.len();

esp-wifi/src/ble/npl.rs

@@ -384,7 +384,7 @@ unsafe extern "C" fn task_create(
     task_handle: *const c_void,
     core_id: u32,
 ) -> i32 {
-    let name_str = str_from_c(name as *const u8);
+    let name_str = str_from_c(name as *const _);
     trace!(
         "task_create {:?} {} {} {:?} {} {:?} {}",
         task_func,

esp-wifi/src/wifi/mod.rs

@@ -1628,6 +1628,7 @@ pub(crate) fn wifi_start() -> Result<(), WifiError> {
             .copy_from_slice(crate::CONFIG.country_code.as_bytes());
         cntry_code[2] = crate::CONFIG.country_code_operating_class;
 
+        #[allow(clippy::useless_transmute)]
         let country = wifi_country_t {
             cc: core::mem::transmute::<[u8; 3], [core::ffi::c_char; 3]>(cntry_code),
             schan: 1,

esp-wifi/src/wifi/os_adapter.rs

@@ -652,7 +652,7 @@ pub unsafe extern "C" fn task_create_pinned_to_core(
 ) -> i32 {
     trace!("task_create_pinned_to_core task_func {:?} name {} stack_depth {} param {:?} prio {}, task_handle {:?} core_id {}",
         task_func,
-        str_from_c(name as *const u8),
+        str_from_c(name as *const _),
         stack_depth,
         param,
         prio,
@@ -1024,6 +1024,7 @@ pub unsafe extern "C" fn phy_enable() {
 ///   Don't support
 ///
 /// *************************************************************************
+#[allow(clippy::unnecessary_cast)]
 pub unsafe extern "C" fn phy_update_country_info(
     country: *const crate::binary::c_types::c_char,
 ) -> crate::binary::c_types::c_int {
@@ -1455,7 +1456,7 @@ pub unsafe extern "C" fn log_write(
     format: *const crate::binary::c_types::c_char,
     args: ...
 ) {
-    crate::binary::log::syslog(level, format as *const u8, args);
+    crate::binary::log::syslog(level, format as *const _, args);
 }
 
 /// **************************************************************************
@@ -1484,7 +1485,7 @@ pub unsafe extern "C" fn log_writev(
 ) {
     crate::binary::log::syslog(
         level,
-        format as *const u8,
+        format as *const _,
         core::mem::transmute::<crate::binary::include::va_list, core::ffi::VaListImpl<'_>>(args),
     );
 }