SPI and related changes #2681
Merged
SPI and related changes #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
spi-fixes
branch
3 times, most recently
from
712fdc4 to
273938f
Compare
bugadani
commented
Dec 5, 2024
| @@ -115,42 +112,43 @@ const MAX_DMA_SIZE: usize = 32736; | |||
| /// | |||
| /// Used to define specific commands sent over the SPI bus. | |||
| /// Can be [Command::None] if command phase should be suppressed. | |||
| #[derive(Copy, Clone, Debug, PartialEq, Eq)] | |||
| #[non_exhaustive] | |||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] | |||
| #[cfg_attr(feature = "defmt", derive(defmt::Format))] | |||
| pub enum Command { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bugadani
force-pushed
the
spi-fixes
branch
2 times, most recently
from
f3acdbd to
270ad92
Compare
playfulFence
approved these changes
Dec 5, 2024
jessebraham
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2678
Closes #2679
Closes #2680
Closes #2685