Fix restoring of CPENABLE #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Oct 9, 2024
| @@ -254,7 +284,7 @@ generic-queue = [ | |||
| integrated-timers = [ | |||
| "esp-hal-embassy/integrated-timers", | |||
| ] | |||
| octal-psram = ["esp-hal/octal-psram", "dep:esp-alloc"] | |||
| octal-psram = ["esp-hal/octal-psram", "esp-alloc"] | |||
There was a problem hiding this comment.
dep: meant there was no implicit esp-alloc feature, which I need in the new test.
bugadani
commented
Oct 9, 2024
bjoernQ
approved these changes
Oct 9, 2024
MabezDev
reviewed
Oct 9, 2024
MabezDev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp-wifi did not save the CPENABLE state, which sometimes resulted in the FPU being turned off. This can happen if esp-wifi decides to switch context in a lower-priority ISR, without
float-save-restorebeing enabled.The original issue is tricky to reproduce because previously we didn't change the word in the stack frame at all, so esp-wifi "restored" what was there before.
With
float-save-restorethis issue shouldn't happen since we don't disable the FPU.