tcp_modbus_accept mustn't close socket on error (closes stephane#333)

The socket management belongs to the application. The return code was missing in modbus_tcp_pi_accept().
epsilonrt · Jul 19, 2016 · 4b723c6 · 4b723c6
1 parent 1c42e59
commit 4b723c6
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/modbus-tcp.c b/src/modbus-tcp.c
@@ -661,8 +661,6 @@ int modbus_tcp_accept(modbus_t *ctx, int *s)
 #endif
 
     if (ctx->s == -1) {
-        close(*s);
-        *s = -1;
         return -1;
     }
 
@@ -691,9 +689,9 @@ int modbus_tcp_pi_accept(modbus_t *ctx, int *s)
 #else
     ctx->s = accept(*s, (struct sockaddr *)&addr, &addrlen);
 #endif
+
     if (ctx->s == -1) {
-        close(*s);
-        *s = -1;
+        return -1;
     }
 
     if (ctx->debug) {