#5224 – Implement basic preview in connection modal for ambiguous monomer #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
rrodionov91
svvald
force-pushed
the
5224-selectedit-connection-points-dialogues-for-ambiguous-monomers
branch
from
ccea823 to
4e98bb0
Compare
rrodionov91
approved these changes
Sep 3, 2024
Comment on lines
+33
to
+35
| if (svg) { | ||
| const svgElement = select(svg); | ||
| if (monomer instanceof AmbiguousMonomer) { |
There was a problem hiding this comment.
Could be simplified like this:
if (!svg || !(monomer instanceof AmbiguousMonomer)) {
return;
}
...
rrodionov91
deleted the
5224-selectedit-connection-points-dialogues-for-ambiguous-monomers
branch
rrodionov91
changed the title
Guch1g0v
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name