Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ketcher does not respond if switch to macromolecules, close popup with ketcher and open again #6379

Closed
Tracked by #6600
rrodionov91 opened this issue Jan 28, 2025 · 1 comment · Fixed by #6380 or #6381
Closed
Tracked by #6600

Ketcher does not respond if switch to macromolecules, close popup with ketcher and open again #6379

rrodionov91 opened this issue Jan 28, 2025 · 1 comment · Fixed by #6380 or #6381
Assignees
@rrodionov91
Milestone
Ketcher 3.0.0-rc.6

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Jan 28, 2025 •
edited
Loading

Steps to Reproduce

  1. Run ketcher in dialog (apply patch -_ketcher_in_dialog_with_open_close_btn.patch)
  2. Click on 'Show Ketcher' button
  3. Switch to macromolecules mode
  4. Click on 'Close Ketcher' button
  5. Click on 'Show Ketcher' button

Actual behavior

  1. Canvas is not responsible to user interaction (f.e. it is impossible to add Benzene ring from library to canvas)
  2. ketcher.setMolecule() does not work

Expected behavior

  1. Canvas is responsible to user interaction (f.e. it is possible to add Benzene ring from library to canvas, select structures e.t.c)
  2. ketcher.setMolecule() works

Ketcher version [e.g. v2.4.2].
Ketcher v3.0.0-rc.5
@rrodionov91 rrodionov91 self-assigned this Jan 28, 2025
@rrodionov91 rrodionov91 added this to the Ketcher 3.0.0-rc.6 milestone Jan 28, 2025
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6379 - Ketcher does not respond if switch to macromolecules, close p…
d5018a3 
…opup with ketcher and open again
@rrodionov91 rrodionov91 linked a pull request Jan 28, 2025 that will close this issue
#6379 - Ketcher does not respond if switch to macromolecules, close popup with ketcher and open again #6380
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6379 - Ketcher does not respond if switch to macromolecules, close p…
2be7705 
…opup with ketcher and open again (#6380)

- clear isPolymerEditorTurnedOn on Editor destroy
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6379 - Ketcher does not respond if switch to macromolecules, close p…
581320f 
…opup with ketcher and open again (#6380)

- clear isPolymerEditorTurnedOn on Editor destroy
@rrodionov91 rrodionov91 linked a pull request Jan 28, 2025 that will close this issue
Backmerge: #6379 - Ketcher does not respond if switch to macromolecules, close popup with ketcher and open again #6381
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 3.0.0-rc.6 Build at 2025-01-28; 21:11:35
  • Indigo Toolkit Version 1.28.0-rc.3.0-gd5bcc27cb-wasm32-wasm-clang-19.0.0
  • Chrome Version 132.0.6834.111 (Official Build) (64-bit)
  • Win10

rrodionov91 added a commit that referenced this issue Jan 29, 2025
@rrodionov91
#6379 - Ketcher does not respond if switch to macromolecules, close p…
9ab78ad 
…opup with ketcher and open again (#6380) (#6381)

- clear isPolymerEditorTurnedOn on Editor destroy
@AlexeyGirin AlexeyGirin mentioned this issue Mar 4, 2025
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
Ketcher 3.0.0-rc.6
2 participants
@rrodionov91 @AlexeyGirin