Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect stereo-label placement for (E) and (Z) #4757

Closed
ljubica-milovic opened this issue Jun 5, 2024 · 2 comments · Fixed by #5511
Closed

Incorrect stereo-label placement for (E) and (Z) #4757

ljubica-milovic opened this issue Jun 5, 2024 · 2 comments · Fixed by #5511
Assignees
@rrodionov91
Labels
Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: Medium Stereochemistry Bucket: Stereochemistry related issues
Milestone
Ketcher 2.26.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

Steps to Reproduce

  1. Go to Ketcher micromolecules mode.
  2. Draw any structure containing cis/trans isomerism. For example:
    image
  3. Select Calculate CIP.

Actual behavior
Ketcher displays the stereo-label towards the end of the bond.
image

Expected behavior
Ketcher should display the label in the center of the double bond, overlapping with it.

Ketcher version v2.22.0
@ljubica-milovic ljubica-milovic added bug Stereochemistry Bucket: Stereochemistry related issues labels Jun 5, 2024
@AlexeyGirin AlexeyGirin added this to the Refined Backlog milestone Jun 6, 2024
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 6, 2024 •
edited
Loading

Rose the priority since @ljubica-milovic found it is common problem and in many places we put label in unusual place

@ljubica-milovic ljubica-milovic mentioned this issue Jun 6, 2024
Open
@rrodionov91 rrodionov91 self-assigned this Sep 13, 2024
rrodionov91 added a commit that referenced this issue Sep 13, 2024
@rrodionov91
#4757 - Incorrect stereo-label placement for (E) and (Z)
a4dc204
@rrodionov91 rrodionov91 linked a pull request Sep 13, 2024 that will close this issue
#4757 - Incorrect stereo-label placement for (E) and (Z) #5511
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 16, 2024
@rrodionov91
#4757 - Incorrect stereo-label placement for (E) and (Z) (#5511)
ebaa800
@AlexeyGirin AlexeyGirin mentioned this issue Sep 24, 2024
Closed
@AlexeyGirin AlexeyGirin added the Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine label Sep 24, 2024
@AlexeyGirin
Copy link
Collaborator

Verified.
image

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#4757 - Incorrect stereo-label placement for (E) and (Z) (#5511)
62a1f6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: Medium Stereochemistry Bucket: Stereochemistry related issues
Projects
None yet
Milestone
Ketcher 2.26.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4757 - Incorrect stereo-label placement for (E) and (Z) epam/ketcher
3 participants
@rrodionov91 @AlexeyGirin @ljubica-milovic