Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow size is wrong if reaction loaded from SMARTS #2662

Closed
AlexeyGirin opened this issue Nov 28, 2024 · 1 comment · Fixed by #2666
Closed

Arrow size is wrong if reaction loaded from SMARTS #2662

AlexeyGirin opened this issue Nov 28, 2024 · 1 comment · Fixed by #2666
Assignees
@even1024
Labels
ACS standard Priority: Low Severity: Medium Medium level visibility to the user
Milestone
Indigo-1.27.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Nov 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Micro
  2. Load to canvas following reaction using paste from clipboard way: [#6]1(-[#6])-[#6](-[#8])=[#6]-[#6](-[#16])=[#6](-[#7])-[#6]=1>>[#6]1(-Br)-[#6](-[#6])=[#6]-[#6](-I)=[#6](-[#8])-[#6]=1

Actual behavior
Arrow size definitely longer than bond size
image

Expected behavior
Arrow size has bond size
image

As per requirements:

Bond length - length of one bond and the length of the default arrows (related issue: #5153);

Versions

  • Ketcher Version 2.28.0-dev.1 Build at 2024-11-28; 06:41:11
  • Version 1.27.0-dev.3.0-g62217e49f-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)
  • Win10

Issue found while testing - epam/ketcher#5152, #2176
@AlexeyGirin AlexeyGirin added Bug Priority: Low Severity: Medium Medium level visibility to the user labels Nov 28, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/ketcher Nov 28, 2024
@github-project-automation github-project-automation bot moved this to Product Backlog in Indigo Nov 28, 2024
@AlexeyGirin AlexeyGirin moved this from Product Backlog to In progress in Indigo Nov 28, 2024
@AlexeyGirin AlexeyGirin removed this from Indigo Nov 28, 2024
@even1024 even1024 added this to the Indigo-1.27.0-rc.1 (Current) milestone Nov 29, 2024
@even1024 even1024 linked a pull request Nov 29, 2024 that will close this issue
#2665, #2664, #2662 - SMILES/SMARTS reaction layout issues #2666
Merged
7 tasks
AlexanderSavelyev pushed a commit that referenced this issue Dec 2, 2024
@even1024
#2665, #2664, #2662 - SMILES/SMARTS reaction layout issues (#2666)
dfa8f2f
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2024

 Tested. Bug fixed.

2024-12-06_11h21_38

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.1]
Indigo version
[Version 1.27.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
ACS standard Priority: Low Severity: Medium Medium level visibility to the user
Projects
None yet
Milestone
Indigo-1.27.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2665, #2664, #2662 - SMILES/SMARTS reaction layout issues epam/Indigo
3 participants
@even1024 @AlexeyGirin @Zhirnoff