-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #228 from thatjessicakelly/warn-about-test-utils
Add warning about implicit dependency on react-addons-test-utils
- Loading branch information
Showing
1 changed file
with
23 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,15 +60,36 @@ if (REACT013) { | |
return TestUtils.renderIntoDocument(node); | ||
}; | ||
} else { | ||
const ReactDOM = require('react-dom'); | ||
let ReactDOM; | ||
|
||
try { | ||
ReactDOM = require('react-dom'); | ||
} catch (e) { | ||
console.error( | ||
'react-dom is an implicit dependency in order to support [email protected]. ' + | ||
'Please add the appropriate version to your devDependencies. ' + | ||
'See https://github.com/airbnb/enzyme#installation' | ||
); | ||
throw e; | ||
} | ||
|
||
renderToStaticMarkup = require('react-dom/server').renderToStaticMarkup; | ||
findDOMNode = ReactDOM.findDOMNode; | ||
unmountComponentAtNode = ReactDOM.unmountComponentAtNode; | ||
// We require the testutils, but they don't come with 0.14 out of the box, so we | ||
// require them here through this node module. The bummer is that we are not able | ||
// to list this as a dependency in package.json and have 0.13 work properly. | ||
// As a result, right now this is basically an implicit dependency. | ||
TestUtils = require('react-addons-test-utils'); | ||
try { | ||
TestUtils = require('react-addons-test-utils'); | ||
} catch (e) { | ||
console.error( | ||
'react-addons-test-utils is an implicit dependency in order to support [email protected]. ' + | ||
'Please add the appropriate version to your devDependencies. ' + | ||
'See https://github.com/airbnb/enzyme#installation' | ||
); | ||
throw e; | ||
} | ||
|
||
// Shallow rendering changed from 0.13 => 0.14 in such a way that | ||
// 0.14 now does not allow shallow rendering of native DOM elements. | ||
|