-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextEdit: fix crash when hitting SHIFT + TAB around non-ASCII text #3984
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
30e5d55
Update text_buffer.rs
rustbasic 77a538f
Merge branch 'emilk:master' into patch4
rustbasic c787081
Merge branch 'emilk:master' into patch4
rustbasic e529d13
Merge branch 'emilk:master' into patch4
rustbasic 647fff9
Merge branch 'emilk:master' into patch4
rustbasic f0a5c6a
Merge branch 'emilk:master' into patch4
rustbasic f43f82a
Merge branch 'emilk:master' into patch4
rustbasic 82d7a93
Merge branch 'emilk:master' into patch4
rustbasic 7dbd6e1
Merge branch 'emilk:master' into patch4
rustbasic 4d5ea14
Merge branch 'emilk:master' into patch4
rustbasic 9916c62
Merge branch 'emilk:master' into patch4
rustbasic 1d80efa
Merge branch 'emilk:master' into patch4
rustbasic 9049953
Merge branch 'emilk:master' into patch4
rustbasic 7af8879
Merge branch 'emilk:master' into patch4
rustbasic 1160f0b
Merge branch 'emilk:master' into patch4
rustbasic 8f0aab4
Merge branch 'emilk:master' into patch4
rustbasic a679f64
Merge branch 'emilk:master' into patch4
rustbasic fad925c
Merge branch 'emilk:master' into patch4
rustbasic 63fd80c
Merge branch 'emilk:master' into patch4
rustbasic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iteration over chars two times can be time consuming for a long text. It is better to do that only once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be, you right.
However, it only works when we press SHIFT + TAB, so we don't need to change it.