Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic when pressing Shift + TAB in a TextEdit #3846

Closed
rustbasic opened this issue Jan 19, 2024 · 0 comments · Fixed by #3984
Closed

panic when pressing Shift + TAB in a TextEdit #3846

rustbasic opened this issue Jan 19, 2024 · 0 comments · Fixed by #3984
Labels
bug Something is broken
Milestone
Next Major Release

Comments

@rustbasic
Copy link
Contributor

rustbasic commented Jan 19, 2024 •
edited
Loading

TextEdit : Shift + TAB

Shift + TAB

UTF8 panic
and other BUG

I work finished it. Pull Request.
@rustbasic rustbasic added the bug Something is broken label Jan 19, 2024
rustbasic added a commit to rustbasic/egui that referenced this issue Jan 19, 2024
@rustbasic
Update text_buffer.rs
4870a54 
Issues 
emilk#3846
This was referenced Jan 19, 2024
Closed
Closed
@emilk emilk changed the title TextEdit : Shift + TAB panic when pressing Shift + TAB in a TextEdit Jan 23, 2024
@emilk emilk added this to the Next Major Release milestone Jan 23, 2024
rustbasic added a commit to rustbasic/egui that referenced this issue Jan 24, 2024
@rustbasic
Fix: panic when pressing Shift + TAB in a TextEdit
b0b842f 
panic when pressing Shift + TAB in a TextEdit emilk#3846
rev() is panic with UTF8

Not byte_index
It's char_index ( for UTF8 )
@rustbasic rustbasic mentioned this issue Jan 24, 2024
Closed
@rustbasic rustbasic mentioned this issue Feb 7, 2024
Merged
emilk pushed a commit that referenced this issue Mar 12, 2024
@rustbasic
TextEdit: fix crash when hitting SHIFT + TAB around non-ASCII text (#…
f019032 
…3984)

* Closes #3846 
* Closes #3878

Dear emilk.

Leaving aside other function,
I think this is all you need to fix to patch the panic that occurs when
Shift + TAB.

Thank you, emilk.
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@rustbasic @hacknus
TextEdit: fix crash when hitting SHIFT + TAB around non-ASCII text (e…
c80da29 
…milk#3984)

* Closes emilk#3846 
* Closes emilk#3878

Dear emilk.

Leaving aside other function,
I think this is all you need to fix to patch the panic that occurs when
Shift + TAB.

Thank you, emilk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging a pull request may close this issue.

TextEdit: fix crash when hitting SHIFT + TAB around non-ASCII text rustbasic/egui
2 participants
@emilk @rustbasic