Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regularize event propagation from views #432

Closed
wagenet opened this issue Jan 24, 2012 · 3 comments
Closed

Regularize event propagation from views #432

wagenet opened this issue Jan 24, 2012 · 3 comments
Labels
Cleanup
Milestone
1.0 RC

Comments

@wagenet
Copy link
Member

wagenet commented Jan 24, 2012

Right now Ember.Button has some support for disabling propagation, whereas other views don't have anything special built in. Also, TextSupport keyUp handler doesn't return a value so it's impossible to control propagation.
@trek
Copy link
Member

trek commented Jul 6, 2012

Is this still the case? There were a lot of commits with event propagation last week.

@wagenet
Copy link
Member Author

wagenet commented Jul 6, 2012

Things do seem a lot better now, should probably verify with @wycats and @tomdale.

@wagenet
Copy link
Member Author

wagenet commented Jul 9, 2012

I think this is covered so I'm closing.

@wagenet wagenet closed this as completed Jul 9, 2012
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
9af48e2 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to huristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST trasnform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
cd98737 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
6590d05 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
303ecfa 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
fc0dba8 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
1b3960c 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
80d052c 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
d483598 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
397d6b9 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
chancancode added a commit that referenced this issue Mar 30, 2021
@chancancode
[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi…
6d430b6 
…fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.

(cherry picked from commit 397d6b9)
sandstrom pushed a commit to sandstrom/ember.js that referenced this issue Jun 17, 2021
@dependabot-preview @RobbieTheWagner
Bump ember-load-initializers from 2.0.0 to 2.1.0 (emberjs#432)
8f16248 
Bumps [ember-load-initializers](https://github.com/ember-cli/ember-load-initializers) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/ember-cli/ember-load-initializers/releases)
- [Changelog](https://github.com/ember-cli/ember-load-initializers/blob/master/CHANGELOG.md)
- [Commits](ember-cli/ember-load-initializers@v2.0.0...v2.1.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
1.0 RC
Development

No branches or pull requests
2 participants
@trek @wagenet