Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-toolchain.toml for developers and CI #167

Merged
merged 1 commit into from
May 9, 2021

Conversation

rukai
Copy link
Contributor

@rukai rukai commented May 8, 2021

The changes are:

I hope my CI changes do what I think they should... I cant really test them locally.

Dependent on: #166

This change could be controversial so I'm happy to discuss it.
The advantages I see here are:

  • CI doesnt break due to nightly regressions or breaking changes.
  • Developers work on a common nightly, preventing differences between nightlies from causing hard to track down issues.
  • Users have a documented nightly version that embassy supports, and they can also copy in the embassy rust-toolchain file without having to setup their own.

A disadvantage is:

  • If a user wants to try building one of the examples it will pull in rustfmt and a target they dont need.

However I dont think that is a big problem because if they are bothered by that they can just move the example into its own crate. Which they will probably want to do eventually anyway if they have interest in using embassy.

@thalesfragoso
Copy link
Member

As a note, I would choose a toolchain with clippy available :)

@rukai rukai force-pushed the use_rust_toolchain_toml branch 2 times, most recently from d6cc4e7 to 854022d Compare May 9, 2021 02:46
@rukai
Copy link
Contributor Author

rukai commented May 9, 2021

Did some research and found this: https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html
I dont know if we care about about miri and rls but I figured I may as well support them by downgrading by one day. So I downgraded to 2021-05-07.

I also fixed the CI build by telling actions-rs/toolchain to use the stable toolchain (which is then superseded by the rust-toolchains.toml)

@Dirbaio
Copy link
Member

Dirbaio commented May 9, 2021

Thanks for the PR! I like this :)

Pinning a particular nightly version is very nice, it'll hopefully help with the random CI failures and allows updating to newer nightlies at our pace

@Dirbaio Dirbaio merged commit 1703700 into embassy-rs:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants