Add fullscreen effect and move to old ws on close #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now actually ready :) The reason we connect to unmanaged and don't do it in destroy () anymore is that the window list only gets fully updated once a window is finished unmanaging. Otherwise we might try to remove a workspace but mutter thinks it has still windows on it which leads to a bail out. |
lenemter
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fullscreening/Unfullscreening will now play the same effect as maximizing and unmaximizing (since it's pretty much just an extended version of that action I think it fits)
Also we will now move to the old ws if a window that was moved to a new ws is closed.
Fixes #1986
Fixes #551
Closes #2146