Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelClone: avoid using Timeout #2015

Merged
merged 5 commits into from
Nov 26, 2024
Merged

PanelClone: avoid using Timeout #2015

merged 5 commits into from
Nov 26, 2024

Conversation

lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team August 10, 2024 14:26
leolost2605
leolost2605 reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks when disabling animation :(

@lenemter lenemter requested a review from leolost2605 August 12, 2024 13:36
leolost2605
leolost2605 reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we can do it like this but wouldn't it maybe then just be easier to stay with the timeout?

@leolost2605 leolost2605 mentioned this pull request Oct 20, 2024
Merged
leolost2605
leolost2605 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually fixes a rare crash so let's got with it
(Can be removed with #2074 anyways)

@leolost2605 leolost2605 merged commit 5adb554 into main Nov 26, 2024
5 checks passed
@leolost2605 leolost2605 deleted the lenemter/use-transition branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenemter @leolost2605 @zeebok