Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragDropAction: Fix memory leak #1950

Merged
merged 5 commits into from
Jun 22, 2024
Merged

DragDropAction: Fix memory leak #1950

merged 5 commits into from
Jun 22, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jun 22, 2024

We've had a ref cycle here leading to pretty big memory consumption if many workspaces were opened and closed again, since all the backgrounds were kept around.

@leolost2605 leolost2605 marked this pull request as ready for review June 22, 2024 15:35
@leolost2605 leolost2605 requested a review from a team June 22, 2024 15:36
@leolost2605 leolost2605 requested a review from lenemter June 22, 2024 16:35
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lenemter lenemter merged commit 18621b9 into master Jun 22, 2024
2 of 4 checks passed
@lenemter lenemter deleted the leolost/fix-memory-leak branch June 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants