ShadowEffect: Dont use Gtk to draw shadows #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
danirabbit
force-pushed
the
leolost/shadow-no-gtk
branch
from
988862c to
41fb322
Compare
|
@leolost2605 Okay I think this is probably good enough. Instead of setting shadow spread, we just take in "css class" as a construction argument Shadows are drawn with a rounded rectangle now and you can set border radius so that works much better for things like the workspace switcher that casts a very small shadow The more shadow spread there is, the further we offset shadows on the y axis. So in other words if an object is high up on the Z axis, the shadow is cast further away from its origin It's not 1:1 to shadows in the stylesheet but I don't think anyone will really notice |
danirabbit
approved these changes
May 27, 2024
|
Let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically reverts #250
Currently it's a regression since we can't do fancy shadow styles using CSS now. I'll try looking into fully supporting CSS box shadow properties but that might take a while