Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework close button #1848

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Rework close button #1848

merged 7 commits into from
Feb 13, 2024

Conversation

lenemter
Copy link
Member

Adds a CloseButton class with a simple scale animation + triggered signal to avoid using ClickAction

@lenemter lenemter requested a review from a team February 10, 2024 15:38
danirabbit
danirabbit approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@danirabbit danirabbit merged commit 0cd3f32 into master Feb 13, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/rework-close-button branch February 13, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenemter @danirabbit