Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Data Sender to leshan client #1274

Closed
wants to merge 19 commits into from
Closed

Adding Data Sender to leshan client #1274

wants to merge 19 commits into from

Conversation

sbernard31
Copy link
Contributor

@sbernard31 sbernard31 commented Jun 28, 2022 •
edited
Loading

This work is based on @adamsero 's work #1268 which aimed to implement #1228

adamsero and others added 18 commits June 27, 2022 15:11
@adamsero @sbernard31
Added ManualDataSender and DataSenderManager plus unit tests.
dcf2126
@sbernard31
Clean format + organize imports
44bf8b8
@sbernard31
Add Some javadoc
71b9997
@sbernard31
Ensure name is not resued by senders
33f9997
@sbernard31
Move DEFAULT_NAME to manual sender
6d1353a
@sbernard31
We should not expose internal builderin ManualDataSender
83f1b12
@sbernard31
Rename getCurrentValue in getCurrentValues
20f9bee
@sbernard31
Rename StringToLwM2mPathConverter to LwM2mPathConverter
d9f7155
@sbernard31
fix merge conflict issue ?
1b52819
@sbernard31
Use exclusive sub command for ( collected-value | current-value)
7b917c3
@sbernard31
handle send with no data collected
3a7eee1
@sbernard31
Use ManualSender in integration tests instead of HACK
b8f01d1
@sbernard31
Reuse data sender in leshan client
7ec7a3c
@sbernard31
DataSendManager should be started after endpoint and engine.
a8a30cd
@sbernard31
Move Class to send Package
3e1d9f9
@sbernard31
Add SendService API to client to regroup everything about Send Request
0e23148
@sbernard31
Move Test in send package too.
2d6f1e9
@sbernard31
fix javadoc issue I introduce at 71b9997
268dca9
@sbernard31
Copy link
Contributor Author

@adamsero, I planned to integrate your work in master before to do that I double checked the code + test it.
Doing minor clean-up, some more ideas come to me and so finally there is more changes than expected.

If you have time, could you review this ? (it will be easier to look at this commit by commit)

@adamsero
Copy link
Contributor

I'll take a look at it today

adamsero
adamsero approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@adamsero adamsero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from those two trifles, overall everything is ok. Good idea abstracting the send service, it might work better for possible future implementations.

This was referenced Jul 1, 2022
Closed
Closed
Closed
@sbernard31
Copy link
Contributor Author

Integrated in master (squashed commit 60a95c2)

@sbernard31 sbernard31 closed this Jul 1, 2022
@sbernard31
Copy link
Contributor Author

Thx @adamsero for the review 👍 !

@sbernard31 sbernard31 mentioned this pull request Jul 1, 2022
Closed
@sbernard31 sbernard31 deleted the data_sender branch July 29, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsero adamsero adamsero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernard31 @adamsero