Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring about Link Format #1197

Closed
wants to merge 52 commits into from
Closed

Refactoring about Link Format #1197

wants to merge 52 commits into from

Conversation

sbernard31
Copy link
Contributor

@sbernard31 sbernard31 commented Jan 14, 2022

This is a refactoring to try to propose a API to bound Attribute and Link world, proposing a kind of LWM2M flavored Link.
Some idea are described at :

This is an huge PR ... I really don't like to do that 😞...
However I tried to make it with a series of "small" consistent commit.

I will probably squash all of this in 1 commit when integrating this in master.

There are renaming work but I think this should be done in some other PRs :
- Use LwM2mLink for discover
- Use Version instead of String for VERSION.
- Add notification/properties kind to model.
- Add range check
- Add applicability check
- quoted version invalid by default ?
- Make linkparser/attribute parser configurable.
Finally done in this PR.

@Michal-Wadowski
Copy link
Contributor

@sbernard31 unfortunately I have limited time recently, so I can't look at this. I believe all the changes are OK 😄

@sbernard31
Copy link
Contributor Author

I think this is in a mergeable state.
I plan to integrate it in master on next Monday.

@sbernard31
Copy link
Contributor Author

This is now integrated in master (commit 30f79d3)

@noor-jafri
Copy link

Noob here, noob to Java and everything. Somehow many stuff mentioned here is not available to the Leshan-Server-Demo. For example:

org.eclipse.leshan.core.link.attributes does not exist.
package org.eclipse.leshan.core.link.lwm2m.attributes does not exist

I tried clean installing.

Can somebody help me here?

When I go into details, checking out the external libraries. I do not see these files are available as it does in Master. Somehow the Maven builds are not new. If that's the case, how do I build jar directly from the master and use them in the demo server?

@sbernard31
Copy link
Contributor Author

Somehow many stuff mentioned here is not available to the Leshan-Server-Demo

Which version are you talking about ? (where/how do you get your "leshan-server-demo" ?

Currently there is no (stable or milestone) release which integrate this. This is available in master.
To build from master : https://github.com/eclipse/leshan#compile-leshan--run-demos

HTH

@sbernard31
Copy link
Contributor Author

You can also download the already built jar of master looking at the https://github.com/eclipse/leshan#readme table (leshan v2.0.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants