-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer enforce to throw #279
Merged
jondegenhardt
merged 12 commits into
eBay:master
from
jondegenhardt:prefer-enforce-to-throw
Mar 29, 2020
Merged
Prefer enforce to throw #279
jondegenhardt
merged 12 commits into
eBay:master
from
jondegenhardt:prefer-enforce-to-throw
Mar 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not allowed to end in zero (eg. 3-0).
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 99.15% 99.24% +0.08%
==========================================
Files 17 17
Lines 5684 5689 +5
==========================================
+ Hits 5636 5646 +10
+ Misses 48 43 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactoring - Prefer
enforce
(fromstd.exception
) over if-test plusthrow new Exception
. Minor, but reduces the volume of code, especially in command line argument validation.Found one bug in the process - Field ranges ending in zero were not getting caught during command line argument checking. Only occurs in cases where zero is a valid value, and its for field ranges in reverse order so a rare case.
Added a couple missed unit tests, all in command line argument validation.