Fix typo in xdebug.md #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Feb 11, 2025
| @@ -15,7 +15,7 @@ XDEBUG_MODE=debug docker compose up -d | |||
| On Windows: | |||
|
|
|||
| ``` | |||
| set XDEBUG_MODE=debug&& docker compose up -d&set XDEBUG_MODE= | |||
| set XDEBUG_MODE=debug && docker compose up -d | |||
There was a problem hiding this comment.
I think we need to keep the reset after the command to reduce side effects, as windows keeps the environment variable during the cmd session.
There was a problem hiding this comment.
You're right! Another issue is that the default terminal on Windows is PowerShell, so the documentation won't work as written, and we need to use cmd for this to function correctly. I will close the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.