Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add dark module #448

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Feat add dark module #448

wants to merge 16 commits into from

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Feb 11, 2025

Description

Importing SVG should be done according to the CRA template.

https://create-react-app.dev/docs/adding-images-fonts-and-files/#adding-svgs

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner February 11, 2025 12:17
@Liam-Zhao Liam-Zhao self-assigned this Feb 11, 2025
@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Feb 11, 2025
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (715adcd) to head (87c1959).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   98.10%   98.23%   +0.12%     
==========================================
  Files          39       41       +2     
  Lines        4282     4475     +193     
  Branches     1375     1489     +114     
==========================================
+ Hits         4201     4396     +195     
+ Misses         71       69       -2     
  Partials       10       10              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
src/components/404/index.tsx 100.00% <ø> (ø)
src/components/card.tsx 100.00% <ø> (ø)
src/components/circular-progress.tsx 100.00% <ø> (ø)
src/components/clusters/edit.tsx 99.54% <100.00%> (ø)
src/components/clusters/index.tsx 95.12% <100.00%> (+0.02%) ⬆️
src/components/clusters/information.tsx 97.57% <100.00%> (ø)
src/components/clusters/new.tsx 100.00% <ø> (ø)
src/components/clusters/peers/index.tsx 98.12% <100.00%> (+0.04%) ⬆️
src/components/clusters/schedulers/index.tsx 98.88% <100.00%> (+0.69%) ⬆️
... and 13 more

... and 12 files with indirect coverage changes

Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant